Mercurial > dwindows

changeset 1714:df5f0857f765

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Looks like there was an incorrect fix for GTK2 combobox misbehavior... A static buffer is returned which gets modified, so we need to duplicate the string on entry so we have the original then free.
author bsmith@81767d24-ef19-dc11-ae90-00e081727c95
date Mon, 07 May 2012 18:07:40 +0000
parents c836c6c33d8e
children e6b139e0b64d
files gtk/dw.c
diffstat 1 files changed, 2 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/gtk/dw.c	Mon May 07 13:56:14 2012 +0000
+++ b/gtk/dw.c	Mon May 07 18:07:40 2012 +0000
@@ -11383,11 +11383,12 @@
 
       if(addtext)
       {
-         const char *defstr = gtk_entry_get_text(GTK_ENTRY(GTK_COMBO(handle2)->entry));
+         char *defstr = strdup(gtk_entry_get_text(GTK_ENTRY(GTK_COMBO(handle2)->entry)));
          tmp = g_list_append(tmp, addtext);
          gtk_object_set_user_data(GTK_OBJECT(handle2), tmp);
          gtk_combo_set_popdown_strings(GTK_COMBO(handle2), tmp);
          gtk_entry_set_text(GTK_ENTRY(GTK_COMBO(handle2)->entry), defstr);
+         free(defstr);
       }
    }
    gtk_object_set_data(GTK_OBJECT(handle), "_dw_appending", NULL);