# HG changeset patch # User bsmith@81767d24-ef19-dc11-ae90-00e081727c95 # Date 1045763288 0 # Node ID a167001c56df96d0c695c457c5aba362bdfa7c89 # Parent 42332e598d55fea6eee863ecc18b1b7bc574fec4 Check that _find_pixmap() returns a pixmap handle before packing the result into the tree item. (GTK 1.x) diff -r 42332e598d55 -r a167001c56df gtk/dw.c --- a/gtk/dw.c Thu Feb 20 11:21:47 2003 +0000 +++ b/gtk/dw.c Thu Feb 20 17:48:08 2003 +0000 @@ -3500,16 +3500,15 @@ hbox = gtk_hbox_new(FALSE, 2); gtk_object_set_data(GTK_OBJECT(newitem), "hbox", (gpointer)hbox); gdkpix = _find_pixmap(&gdkbmp, icon, hbox, NULL, NULL); -#if GTK_MAJOR_VERSION > 1 - pixmap = gtk_image_new_from_pixmap(gdkpix, gdkbmp); -#else - pixmap = gtk_pixmap_new(gdkpix, gdkbmp); -#endif gtk_container_add(GTK_CONTAINER(newitem), hbox); - gtk_box_pack_start(GTK_BOX(hbox), pixmap, FALSE, TRUE, 0); + if(gdkpix) + { + pixmap = gtk_pixmap_new(gdkpix, gdkbmp); + gtk_box_pack_start(GTK_BOX(hbox), pixmap, FALSE, TRUE, 0); + gtk_widget_show(pixmap); + } gtk_box_pack_start(GTK_BOX(hbox), label, FALSE, TRUE, 0); gtk_widget_show(label); - gtk_widget_show(pixmap); gtk_widget_show(hbox); if(parent) @@ -3619,16 +3618,15 @@ hbox = gtk_hbox_new(FALSE, 2); gtk_object_set_data(GTK_OBJECT(item), "hbox", (gpointer)hbox); gdkpix = _find_pixmap(&gdkbmp, icon, hbox, NULL, NULL); -#if GTK_MAJOR_VERSION > 1 - pixmap = gtk_image_new_from_pixmap(gdkpix, gdkbmp); -#else - pixmap = gtk_pixmap_new(gdkpix, gdkbmp); -#endif gtk_container_add(GTK_CONTAINER(item), hbox); - gtk_box_pack_start(GTK_BOX(hbox), pixmap, FALSE, TRUE, 0); + if(gdkpix) + { + pixmap = gtk_pixmap_new(gdkpix, gdkbmp); + gtk_box_pack_start(GTK_BOX(hbox), pixmap, FALSE, TRUE, 0); + gtk_widget_show(pixmap); + } gtk_box_pack_start(GTK_BOX(hbox), label, FALSE, TRUE, 0); gtk_widget_show(label); - gtk_widget_show(pixmap); gtk_widget_show(hbox); if(parent) @@ -3726,16 +3724,15 @@ hbox = gtk_hbox_new(FALSE, 2); gtk_object_set_data(GTK_OBJECT(item), "hbox", (gpointer)hbox); gdkpix = _find_pixmap(&gdkbmp, icon, hbox, NULL, NULL); -#if GTK_MAJOR_VERSION > 1 - pixmap = gtk_image_new_from_pixmap(gdkpix, gdkbmp); -#else - pixmap = gtk_pixmap_new(gdkpix, gdkbmp); -#endif gtk_container_add(GTK_CONTAINER(item), hbox); - gtk_box_pack_start(GTK_BOX(hbox), pixmap, FALSE, TRUE, 0); + if(gdkpix) + { + pixmap = gtk_pixmap_new(gdkpix, gdkbmp); + gtk_box_pack_start(GTK_BOX(hbox), pixmap, FALSE, TRUE, 0); + gtk_widget_show(pixmap); + } gtk_box_pack_start(GTK_BOX(hbox), label, FALSE, TRUE, 0); gtk_widget_show(label); - gtk_widget_show(pixmap); gtk_widget_show(hbox); DW_MUTEX_UNLOCK; #endif