# HG changeset patch # User bsmith@81767d24-ef19-dc11-ae90-00e081727c95 # Date 1613452948 0 # Node ID 1f85311baa65f3da1e446c58b918c60d76b91931 # Parent 112595f9a645cb2073d9fedaec909d491a7c1e27 GTK4: dw_pixmap_new_from_data() should return NULL on failure. Move dw_pixmap_destroy() into thread safety. diff -r 112595f9a645 -r 1f85311baa65 gtk4/dw.c --- a/gtk4/dw.c Tue Feb 16 05:09:26 2021 +0000 +++ b/gtk4/dw.c Tue Feb 16 05:22:28 2021 +0000 @@ -6845,6 +6845,11 @@ unlink(template); pixmap->handle = handle; } + else + { + free(pixmap); + pixmap = 0; + } } DW_FUNCTION_RETURN_THIS(pixmap); } @@ -6924,13 +6929,17 @@ * pixmap: Handle to a pixmap returned by * dw_pixmap_new.. */ -void dw_pixmap_destroy(HPIXMAP pixmap) +DW_FUNCTION_DEFINITION(dw_pixmap_destroy, void, HPIXMAP pixmap) +DW_FUNCTION_ADD_PARAM1(pixmap) +DW_FUNCTION_NO_RETURN(dw_pixmap_destroy) +DW_FUNCTION_RESTORE_PARAM1(pixmap, HPIXMAP) { g_object_unref(G_OBJECT(pixmap->pixbuf)); cairo_surface_destroy(pixmap->image); if(pixmap->font) free(pixmap->font); free(pixmap); + DW_FUNCTION_RETURN_NOTHING; } /*