comparison win/dw.c @ 2618:156ad91481eb

WARNING: Standardize button press and release button parameter values. This may break existing code using 3rd mouse button press/release events. The motion callback and OS/2 had been passing the 3rd mouse button as value 4. Other platforms were passing it as value 3. Since button/press and release events only have a single button values 1,2,3 were unique... but OS/2 was passing the mask value instead, making these not work cross platform. I decided to make the button press/release and motion events all function the same. Passing the mask values instead of button numbers. This change will only affect button 3 on button press or release events on Windows, Mac and GTK. OS/2 already functioned this way, iOS and Android do not support button 3.
author bsmith@81767d24-ef19-dc11-ae90-00e081727c95
date Fri, 23 Jul 2021 20:26:56 +0000
parents d17e3fb76bde
children 2e804b4db81e
comparison
equal deleted inserted replaced
2617:d17e3fb76bde 2618:156ad91481eb
2318 int button=0; 2318 int button=0;
2319 2319
2320 switch(origmsg) 2320 switch(origmsg)
2321 { 2321 {
2322 case WM_LBUTTONDOWN: 2322 case WM_LBUTTONDOWN:
2323 button = 1; 2323 button = DW_BUTTON1_MASK;
2324 break; 2324 break;
2325 case WM_RBUTTONDOWN: 2325 case WM_RBUTTONDOWN:
2326 button = 2; 2326 button = DW_BUTTON2_MASK;
2327 break; 2327 break;
2328 case WM_MBUTTONDOWN: 2328 case WM_MBUTTONDOWN:
2329 button = 3; 2329 button = DW_BUTTON3_MASK;
2330 break; 2330 break;
2331 } 2331 }
2332 if(taskbar) 2332 if(taskbar)
2333 { 2333 {
2334 POINT ptl; 2334 POINT ptl;
2353 int button=0; 2353 int button=0;
2354 2354
2355 switch(origmsg) 2355 switch(origmsg)
2356 { 2356 {
2357 case WM_LBUTTONUP: 2357 case WM_LBUTTONUP:
2358 button = 1; 2358 button = DW_BUTTON1_MASK;
2359 break; 2359 break;
2360 case WM_RBUTTONUP: 2360 case WM_RBUTTONUP:
2361 button = 2; 2361 button = DW_BUTTON2_MASK;
2362 break; 2362 break;
2363 case WM_MBUTTONUP: 2363 case WM_MBUTTONUP:
2364 button = 3; 2364 button = DW_BUTTON3_MASK;
2365 break; 2365 break;
2366 } 2366 }
2367 if(taskbar) 2367 if(taskbar)
2368 { 2368 {
2369 POINT ptl; 2369 POINT ptl;